niansa-misc/musl
1
0
Fork 0
mirror of git://git.musl-libc.org/musl synced 2025-03-06 20:48:29 +01:00
Code Issues Projects Releases Packages Wiki Activity

further optimize getc/putc when locking is needed

Browse source 
check whether the lock is free before loading the calling thread's
tid. if so, just use a dummy tid value that cannot compare equal to
any actual thread id (because it's one bit wider). this also avoids
the need to save the tid and pass it to locking_getc or locking_putc,
reducing register pressure.

this change might slightly hurt the case where the caller already
holds the lock, but it does not affect the single-threaded case, and
may significantly improve the multi-threaded case, especially on archs
where loading the thread pointer is disproportionately expensive like
early mips and arm ISA levels. but even on i386 it helps, at least on
some machines; I measured roughly a 10-15% improvement.
This commit is contained in:
Rich Felker 2018-10-18 12:47:26 -04:00
parent 7eda27d025
commit 9dd1912256
2 changed files with 10 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/stdio/getc.h
View file

@ -4,9 +4,9 @@
#ifdef __GNUC__
__attribute__((__noinline__))
#endif
static int locking_getc(FILE *f, int tid)
static int locking_getc(FILE *f)
{
if (a_cas(&f->lock, 0, tid)) __lockfile(f);
if (a_cas(&f->lock, 0, MAYBE_WAITERS-1)) __lockfile(f);
int c = getc_unlocked(f);
if (a_swap(&f->lock, 0) & MAYBE_WAITERS)
__wake(&f->lock, 1, 1);
@ -15,8 +15,8 @@ static int locking_getc(FILE *f, int tid)
static inline int do_getc(FILE *f)
{
int tid, l = f->lock;
if (l < 0 || (l & ~MAYBE_WAITERS) == (tid=__pthread_self()->tid))
int l = f->lock;
if (l < 0 || l && (l & ~MAYBE_WAITERS) == __pthread_self()->tid)
return getc_unlocked(f);
return locking_getc(f, tid);
return locking_getc(f);
}

10
src/stdio/putc.h
View file

@ -4,9 +4,9 @@
#ifdef __GNUC__
__attribute__((__noinline__))
#endif
static int locking_putc(int c, FILE *f, int tid)
static int locking_putc(int c, FILE *f)
{
if (a_cas(&f->lock, 0, tid)) __lockfile(f);
if (a_cas(&f->lock, 0, MAYBE_WAITERS-1)) __lockfile(f);
c = putc_unlocked(c, f);
if (a_swap(&f->lock, 0) & MAYBE_WAITERS)
__wake(&f->lock, 1, 1);
@ -15,8 +15,8 @@ static int locking_putc(int c, FILE *f, int tid)
static inline int do_putc(int c, FILE *f)
{
int tid, l = f->lock;
if (l < 0 || (l & ~MAYBE_WAITERS) == (tid=__pthread_self()->tid))
int l = f->lock;
if (l < 0 || l && (l & ~MAYBE_WAITERS) == __pthread_self()->tid)
return putc_unlocked(c, f);
return locking_putc(c, f, tid);
return locking_putc(c, f);
}