niansa-misc/musl
1
0
Fork 0
mirror of git://git.musl-libc.org/musl synced 2025-03-06 20:48:29 +01:00
Code Issues Projects Releases Packages Wiki Activity

remove spurious lock in popen

Browse source 
the newly allocated FILE * has not yet leaked to the application and
is only visible to stdio internals until popen returns. since we do
not change any fields of the structure observed by libc internals,
only the pipe_pid member, locking is not necessary.
This commit is contained in:
Rich Felker 2021-04-20 14:52:08 -04:00
parent 9a40e842df
commit e74acd59a5
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/stdio/popen.c
View file

@ -31,7 +31,6 @@ FILE *popen(const char *cmd, const char *mode)
__syscall(SYS_close, p[1]);
return NULL;
}
FLOCK(f);
e = ENOMEM;
if (!posix_spawn_file_actions_init(&fa)) {
@ -43,7 +42,6 @@ FILE *popen(const char *cmd, const char *mode)
if (!strchr(mode, 'e'))
fcntl(p[op], F_SETFD, 0);
__syscall(SYS_close, p[1-op]);
FUNLOCK(f);
return f;
}
}