niansa-misc/wine
1
0
Fork 0
mirror of synced 2025-03-07 03:53:26 +01:00
Code Issues Projects Releases Packages Wiki Activity

msvcrt: Free previous environment variable when clearing.

Browse source 
Shifting the rest of the variables by one towards indices of lesser value
overwrites the variable being cleared and effectively leaks it.

Signed-off-by: David Kahurani <k.kahurani@gmail.com>
This commit is contained in:
David Kahurani 2024-01-26 16:08:33 +03:00 • committed by Alexandre Julliard
parent 9164cf8fd9
commit 1580c1133a
1 changed files with 2 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
dlls/msvcrt/environ.c
View file

@ -161,6 +161,7 @@ static int env_set(char **env, wchar_t **wenv)
*eq = '='; *eq = '=';
if (!eq[1]) if (!eq[1])
{ {
free(MSVCRT__environ[idx]);
for(; MSVCRT__environ[idx]; idx++) for(; MSVCRT__environ[idx]; idx++)
MSVCRT__environ[idx] = MSVCRT__environ[idx + 1]; MSVCRT__environ[idx] = MSVCRT__environ[idx + 1];
} }
@ -187,6 +188,7 @@ static int env_set(char **env, wchar_t **wenv)
*weq = '='; *weq = '=';
if (!weq[1]) if (!weq[1])
{ {
free(MSVCRT__wenviron[idx]);
for(; MSVCRT__wenviron[idx]; idx++) for(; MSVCRT__wenviron[idx]; idx++)
MSVCRT__wenviron[idx] = MSVCRT__wenviron[idx + 1]; MSVCRT__wenviron[idx] = MSVCRT__wenviron[idx + 1];
} }