niansa-misc/wine
1
0
Fork 0
mirror of synced 2025-03-07 03:53:26 +01:00
Code Issues Projects Releases Packages Wiki Activity

jscript: Properly handle passing undefined value to Number.toString in ES5+ mode.

Browse source 
Signed-off-by: Gabriel Ivăncescu <gabrielopcode@gmail.com>
This commit is contained in:
Gabriel Ivăncescu 2023-06-22 16:19:01 +03:00 • committed by Alexandre Julliard
parent 3d04d052cd
commit 38f6eb34b8
3 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
dlls/jscript/number.c
View file

@ -239,7 +239,7 @@ static HRESULT Number_toString(script_ctx_t *ctx, jsval_t vthis, WORD flags, uns
if(FAILED(hres)) if(FAILED(hres))
return hres; return hres;
if(argc) { if(argc && (ctx->version < SCRIPTLANGUAGEVERSION_ES5 || !is_undefined(argv[0]))) {
hres = to_int32(ctx, argv[0], &radix); hres = to_int32(ctx, argv[0], &radix);
if(FAILED(hres)) if(FAILED(hres))
return hres; return hres;

1
dlls/jscript/tests/api.js
View file

@ -2709,6 +2709,7 @@ testException(function() {Number.prototype.toFixed.call(arr);}, "E_NOT_NUM");
testException(function() {Number.prototype.toLocaleString.call(arr);}, "E_NOT_NUM"); testException(function() {Number.prototype.toLocaleString.call(arr);}, "E_NOT_NUM");
testException(function() {Number.prototype.toLocaleString.call(null);}, "E_NOT_NUM"); testException(function() {Number.prototype.toLocaleString.call(null);}, "E_NOT_NUM");
testException(function() {(new Number(3)).toString(1);}, "E_INVALID_CALL_ARG"); testException(function() {(new Number(3)).toString(1);}, "E_INVALID_CALL_ARG");
testException(function() {(new Number(3)).toString(undefined);}, "E_INVALID_CALL_ARG");
testException(function() {(new Number(3)).toFixed(21);}, "E_FRACTION_DIGITS_OUT_OF_RANGE"); testException(function() {(new Number(3)).toFixed(21);}, "E_FRACTION_DIGITS_OUT_OF_RANGE");
testException(function() {(new Number(1)).toPrecision(0);}, "E_PRECISION_OUT_OF_RANGE"); testException(function() {(new Number(1)).toPrecision(0);}, "E_PRECISION_OUT_OF_RANGE");
if(invokeVersion < 2) if(invokeVersion < 2)

3
dlls/mshtml/tests/es5.js
View file

@ -1127,6 +1127,9 @@ sync_test("toString", function() {
obj = Object.create(Number.prototype); obj = Object.create(Number.prototype);
tmp = Object.prototype.toString.call(obj); tmp = Object.prototype.toString.call(obj);
ok(tmp === "[object Object]", "toString.call(Object.create(Number.prototype)) = " + tmp); ok(tmp === "[object Object]", "toString.call(Object.create(Number.prototype)) = " + tmp);
tmp = (new Number(303)).toString(undefined);
ok(tmp === "303", "Number 303 toString(undefined) = " + tmp);
}); });
sync_test("bind", function() { sync_test("bind", function() {