niansa-misc/wine
1
0
Fork 0
mirror of synced 2025-03-07 03:53:26 +01:00
Code Issues Projects Releases Packages Wiki Activity

oleaut32: Lock ITypeLib2 interface reference count behind the typelib cache critical section on Release.

Browse source 
This prevents an ITypeLib2 interface being returned from the typelib
cache that is in the middle of being destroyed.

Signed-off-by: Connor McAdams <cmcadams@codeweavers.com>
This commit is contained in:
Connor McAdams 2023-11-08 08:15:19 -05:00 • committed by Alexandre Julliard
parent eb8eccbed4
commit 3e84b49305
1 changed files with 5 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
dlls/oleaut32/typelib.c
View file

@ -4712,7 +4712,10 @@ static ULONG WINAPI ITypeLib2_fnAddRef( ITypeLib2 *iface)
static ULONG WINAPI ITypeLib2_fnRelease( ITypeLib2 *iface)
{
ITypeLibImpl *This = impl_from_ITypeLib2(iface);
ULONG ref = InterlockedDecrement(&This->ref);
ULONG ref;
EnterCriticalSection(&cache_section);
ref = InterlockedDecrement(&This->ref);
TRACE("%p, refcount %lu.\n", iface, ref);
@ -4728,10 +4731,8 @@ static ULONG WINAPI ITypeLib2_fnRelease( ITypeLib2 *iface)
if(This->path)
{
TRACE("removing from cache list\n");
EnterCriticalSection(&cache_section);
if(This->entry.next)
list_remove(&This->entry);
LeaveCriticalSection(&cache_section);
free(This->path);
}
TRACE(" destroying ITypeLib(%p)\n",This);
@ -4783,9 +4784,9 @@ static ULONG WINAPI ITypeLib2_fnRelease( ITypeLib2 *iface)
}
free(This->typeinfos);
free(This);
return 0;
}
LeaveCriticalSection(&cache_section);
return ref;
}