niansa-misc/wine
1
0
Fork 0
mirror of synced 2025-03-07 03:53:26 +01:00
Code Issues Projects Releases Packages Wiki Activity

opengl32: Add a FIXME when doing a mapped buffer copy.

Browse source 
The copies of mapped buffers introduce significant performance overhead.
This commit is contained in:
Aida Jonikienė 2023-11-26 11:51:27 +02:00 • committed by Alexandre Julliard
parent ebb5bd64a0
commit 5529b00a44
1 changed files with 5 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
dlls/opengl32/unix_wgl.c
View file

@ -1855,10 +1855,15 @@ static void unmap_named_buffer( TEB *teb, GLint buffer )
static NTSTATUS wow64_map_buffer( TEB *teb, GLint buffer, GLenum target, void *ptr, SIZE_T size, static NTSTATUS wow64_map_buffer( TEB *teb, GLint buffer, GLenum target, void *ptr, SIZE_T size,
GLbitfield access, PTR32 *ret ) GLbitfield access, PTR32 *ret )
{ {
static unsigned int once;
if (*ret) /* wow64 pointer provided, map buffer to it */ if (*ret) /* wow64 pointer provided, map buffer to it */
{ {
if (!(access & (GL_MAP_INVALIDATE_RANGE_BIT | GL_MAP_INVALIDATE_BUFFER_BIT))) if (!(access & (GL_MAP_INVALIDATE_RANGE_BIT | GL_MAP_INVALIDATE_BUFFER_BIT)))
{ {
if (!once++)
FIXME( "Doing a copy of a mapped buffer (expect performance issues)\n" );
TRACE( "Copying %#zx from buffer at %p to wow64 buffer %p\n", size, ptr, UlongToPtr(*ret) ); TRACE( "Copying %#zx from buffer at %p to wow64 buffer %p\n", size, ptr, UlongToPtr(*ret) );
memcpy( UlongToPtr(*ret), ptr, size ); memcpy( UlongToPtr(*ret), ptr, size );
} }