niansa-misc/wine
1
0
Fork 0
mirror of synced 2025-03-07 03:53:26 +01:00
Code Issues Projects Releases Packages Wiki Activity

dbghelp: Don't fail in SymAddSymbol for modules without debug information.

Browse source 
Signed-off-by: Eric Pouech <epouech@codeweavers.com>
This commit is contained in:
Eric Pouech 2024-03-01 13:14:06 +01:00 • committed by Alexandre Julliard
parent 61f9f5a05f
commit 6ab88cafaa
2 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
dlls/dbghelp/module.c
View file

@ -404,8 +404,9 @@ BOOL module_load_debug(struct module* module)
if (!ret) module->module.SymType = SymNone;
assert(module->module.SymType != SymDeferred);
module->module.NumSyms = module->ht_symbols.num_elts;
return ret;
}
return module->module.SymType != SymNone;
return TRUE;
}
/******************************************************************
@ -416,7 +417,6 @@ BOOL module_load_debug(struct module* module)
* the module itself)
* - if the module has no debug info and has an ELF container, then return the ELF
* container (and also force the ELF container's debug info loading if deferred)
* - otherwise return the module itself if it has some debug info
*/
BOOL module_get_debug(struct module_pair* pair)
{

2
dlls/dbghelp/tests/path.c
View file

@ -1884,7 +1884,6 @@ static void test_load_modules_details(void)
SymFromNameW(dummy, L"foo", sym);
}
ret = SymAddSymbol(dummy, base, "winetest_symbol_virtual", base + 4242, 13, 0);
todo_wine_if(i == 8 || i == 9 || (i >= 12 && i <= 15)) { /* temp */
ok(ret, "Failed to add symbol\n");
memset(sym, 0, sizeof(*sym));
sym->SizeOfStruct = sizeof(*sym);
@ -1899,7 +1898,6 @@ static void test_load_modules_details(void)
ret = SymFromNameW(dummy, sym_name, (void*)sym);
ok(ret, "Couldn't find symbol %ls\n", sym_name);
}
} /* temp */
ret = SymCleanup(dummy);
ok(ret, "SymCleanup failed: %lu\n", GetLastError());
for (ptr = test->test_files; *ptr; ptr++)