niansa-misc/wine
1
0
Fork 0
mirror of synced 2025-03-07 03:53:26 +01:00
Code Issues Projects Releases Packages Wiki Activity

shell32: Do not set the default menu item from ShellView_DoContextMenu().

Browse source 
This was added in f045c9df81, with no explanation.

It does not affect any behaviour in Wine, since FWF_DESKTOP is never set.

It does not make sense, since "open" is already usually the default action on
Windows, and it's not obvious why FWF_DESKTOP would affect this.

It also leans on IContextMenu implementation details.
This commit is contained in:
Zebediah Figura 2024-02-16 22:02:54 -06:00 • committed by Alexandre Julliard
parent d9c4f506fd
commit 6fd349c6e0
1 changed files with 0 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
dlls/shell32/shlview.c
View file

@ -1039,9 +1039,6 @@ static void ShellView_DoContextMenu(IShellViewImpl * This, WORD x, WORD y, BOOL
/* let the ContextMenu merge its items in */
if (SUCCEEDED(IContextMenu_QueryContextMenu( pContextMenu, hMenu, 0, FCIDM_SHVIEWFIRST, FCIDM_SHVIEWLAST, wFlags )))
{
if (This->FolderSettings.fFlags & FWF_DESKTOP)
SetMenuDefaultItem(hMenu, FCIDM_SHVIEW_OPEN, MF_BYCOMMAND);
if( bDefault )
{
TRACE("-- get menu default command\n");