niansa-misc/wine
1
0
Fork 0
mirror of synced 2025-03-07 03:53:26 +01:00
Code Issues Projects Releases Packages Wiki Activity

ntdll/tests: Fix incorrect calculation of context length in test_copy_context().

Browse source 
`(BYTE *)dst_ex - (BYTE *)dst` is the size of the legacy context, but
`dst_ex->All` already contains the legacy context.  Therefore,
`context_length` has the legacy context size added *twice*.

This becomes a problem when `context_length` exceeds
`sizeof(src_context_buffer)`.  This confuses `check_changes_in_range()`,
causing out-of-bounds read and unpredictable test results.
This commit is contained in:
Jinoh Kang 2024-01-06 22:13:17 +09:00 • committed by Alexandre Julliard
parent 3995ff240a
commit 7ba9dea999
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
dlls/ntdll/tests/exception.c
View file

@ -11952,7 +11952,7 @@ static void test_copy_context(void)
*(DWORD *)((BYTE *)dst + flags_offset) = 0;
*(DWORD *)((BYTE *)src + flags_offset) = 0;
context_length = (BYTE *)dst_ex - (BYTE *)dst + dst_ex->All.Length;
context_length = dst_ex->All.Length;
if (flags & 0x40)
{