niansa-misc/wine
1
0
Fork 0
mirror of synced 2025-03-07 03:53:26 +01:00
Code Issues Projects Releases Packages Wiki Activity

user32/tests: Do not stop checking the message list when skipping an optional or unsupported message.

Browse source 
This was either added by accident, or in an attempt to stop checking the message
list once we hit a winevent hook todo [and accidentally given too wide of a
scope]. However, the same commit also uses a global counter to ensure that only
one winevent todo is printed, so we don't need to break in the first hunk
anyway.

For trailing winevent todos, there is no global counter, so instead move the
goto inside the if block.

Fixes: a72bffe768

The test marked todo here was broken by 33617af814, which was hidden due to the above commit.
This commit is contained in:
Zebediah Figura 2023-03-02 19:56:08 -06:00 • committed by Alexandre Julliard
parent 9b6f65cc09
commit a8c56b1939
1 changed files with 2 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
dlls/user32/tests/msg.c
View file

@ -2853,7 +2853,6 @@ static void ok_sequence_(const struct message *expected_list, const char *contex
}
}
expected++;
goto done;
}
else if (todo)
{
@ -2888,9 +2887,9 @@ static void ok_sequence_(const struct message *expected_list, const char *contex
ok_( file, line) (FALSE, "%s: %u: the msg sequence is not complete: expected 0x%04x - actual 0x%04x\n",
context, count, expected->message, actual->message);
}
goto done;
}
expected++;
goto done;
}
if (todo)
@ -5794,7 +5793,7 @@ static void test_messages(void)
test_WM_SETREDRAW(hchild);
ShowWindow(hchild, SW_SHOW);
ok_sequence(WmShowChildSeq, "ShowWindow(SW_SHOW):child", FALSE);
ok_sequence(WmShowChildSeq, "ShowWindow(SW_SHOW):child", TRUE);
/* check parent messages too */
log_all_parent_messages++;