niansa-misc/wine
1
0
Fork 0
mirror of synced 2025-03-07 03:53:26 +01:00
Code Issues Projects Releases Packages Wiki Activity

gdiplus: Add new test cases to GdipCreateCustomLineCap.

Browse source
This commit is contained in:
Bartosz Kosiorek 2023-08-11 18:27:00 +02:00 • committed by Alexandre Julliard
parent af3014b3e1
commit c4248e97c2
2 changed files with 36 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
dlls/gdiplus/customlinecap.c
View file

@ -105,8 +105,9 @@ static GpStatus init_custom_linecap(GpCustomLineCap *cap, GpPathData *pathdata,
return Ok;
}
/* FIXME: Sometimes when fillPath is non-null and stroke path is null, the native
* version of this function returns NotImplemented. I cannot figure out why. */
/* Custom line cap position (0, 0) is a place corresponding to the end of line.
* If Custom Line Cap is too big and too far from position (0, 0),
* then NotImplemented will be returned, due to floating point precision limitation. */
GpStatus WINGDIPAPI GdipCreateCustomLineCap(GpPath* fillPath, GpPath* strokePath,
GpLineCap baseCap, REAL baseInset, GpCustomLineCap **customCap)
{

40
dlls/gdiplus/tests/customlinecap.c
View file

@ -49,17 +49,22 @@ static BOOL compare_float(float f, float g, unsigned int ulps)
static void test_constructor_destructor(void)
{
GpCustomLineCap *custom;
GpPath *path, *path2;
GpPath *path, *path2, *pathFarAway;
GpStatus stat;
stat = GdipCreatePath(FillModeAlternate, &path);
expect(Ok, stat);
stat = GdipAddPathRectangle(path, 5.0, 5.0, 10.0, 10.0);
stat = GdipAddPathRectangle(path, -5.0, -4.0, 10.0, 8.0);
expect(Ok, stat);
stat = GdipCreatePath(FillModeAlternate, &path2);
expect(Ok, stat);
stat = GdipAddPathRectangle(path2, 5.0, 5.0, 10.0, 10.0);
stat = GdipAddPathRectangle(path2, -5.0, -5.0, 10.0, 10.0);
expect(Ok, stat);
stat = GdipCreatePath(FillModeAlternate, &pathFarAway);
expect(Ok, stat);
stat = GdipAddPathRectangle(pathFarAway, 5.0, 5.0, 10.0, 10.0);
expect(Ok, stat);
/* NULL args */
@ -74,18 +79,39 @@ static void test_constructor_destructor(void)
stat = GdipDeleteCustomLineCap(NULL);
expect(InvalidParameter, stat);
/* valid args */
stat = GdipCreateCustomLineCap(NULL, path2, LineCapFlat, 0.0, &custom);
/* If both parameters are provided, then fillPath will be ignored. */
custom = NULL;
stat = GdipCreateCustomLineCap(path, path2, LineCapFlat, 0.0, &custom);
expect(Ok, stat);
ok(custom != NULL, "Custom line cap was not created\n");
stat = GdipDeleteCustomLineCap(custom);
expect(Ok, stat);
/* it's strange but native returns NotImplemented on stroke == NULL */
/* valid args */
custom = NULL;
stat = GdipCreateCustomLineCap(path, NULL, LineCapFlat, 10.0, &custom);
stat = GdipCreateCustomLineCap(NULL, path2, LineCapFlat, 0.0, &custom);
expect(Ok, stat);
ok(custom != NULL, "Custom line cap was not created\n");
stat = GdipDeleteCustomLineCap(custom);
expect(Ok, stat);
custom = NULL;
stat = GdipCreateCustomLineCap(path, NULL, LineCapFlat, 0.0, &custom);
expect(Ok, stat);
ok(custom != NULL, "Custom line cap was not created\n");
stat = GdipDeleteCustomLineCap(custom);
expect(Ok, stat);
/* Custom line cap position (0, 0) is a place corresponding to the end of line.
* If Custom Line Cap is too big and too far from position (0, 0),
* then NotImplemented will be returned, due to floating point precision limitation. */
custom = NULL;
stat = GdipCreateCustomLineCap(pathFarAway, NULL, LineCapFlat, 10.0, &custom);
todo_wine expect(NotImplemented, stat);
todo_wine ok(custom == NULL, "Expected a failure on creation\n");
if(stat == Ok) GdipDeleteCustomLineCap(custom);
GdipDeletePath(pathFarAway);
GdipDeletePath(path2);
GdipDeletePath(path);
}