niansa-misc/wine
1
0
Fork 0
mirror of synced 2025-03-07 03:53:26 +01:00
Code Issues Projects Releases Packages Wiki Activity

winebus: Ignore udev events of devices which do not have devnodes.

Browse source 
Udev monitor monitors the whole input subsystem, but not all devices
in the input subsystem have devnodes associated to them.

This commit makes the event processing ignore such devices.

All device handling assumes devices have devnodes, so here we just
simply ignore all devices which do not have one.

Previously, udev bus thread aborted when an event for a device without
a devnode was processed:

  10111.330:0068:0084:trace:hid:process_monitor_event Received action "remove" for udev device (null)
  10111.330:0068:0084:warn:hid:bus_main_thread L"UDEV" bus wait returned status 0xc0000005

Just plugging in and out a normal mouse was enough cause this.

This was because root input devices (which do not have devnodes) were
handled too and find_device_from_devnode() choked on NULL argument.
This commit is contained in:
Tuomas Räsänen 2024-03-22 11:41:25 +02:00 • committed by Alexandre Julliard
parent 37d71415ed
commit ef58b8c770
1 changed files with 19 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
dlls/winebus.sys/bus_udev.c
View file

@ -1710,26 +1710,38 @@ static void process_monitor_event(struct udev_monitor *monitor)
{
struct base_device *impl;
struct udev_device *dev;
const char *action;
const char *action, *devnode, *syspath;
dev = udev_monitor_receive_device(monitor);
if (!dev)
{
FIXME("Failed to get device that has changed\n");
ERR("Failed to get device that has changed\n");
return;
}
action = udev_device_get_action(dev);
TRACE("Received action %s for udev device %s\n", debugstr_a(action),
debugstr_a(udev_device_get_devnode(dev)));
syspath = udev_device_get_syspath(dev);
devnode = udev_device_get_devnode(dev);
TRACE("Received action %s for udev device %s (%p) devnode %s\n",
debugstr_a(action), debugstr_a(syspath), dev, debugstr_a(devnode));
if (!action)
WARN("No action received\n");
if (!syspath)
ERR("udev device %p does not have syspath!\n", dev);
else if (!action)
ERR("event for udev device %s does not have any action!\n", syspath);
else if (!devnode)
{
/* Pretty normal case, not all devices have associated
* devnodes. For example root input devices do not, but
* related/child mouse and event devices do.
*/
TRACE("udev device %s does not have devnode, ignoring\n", syspath);
}
else if (strcmp(action, "remove"))
udev_add_device(dev, -1);
else
{
impl = find_device_from_devnode(udev_device_get_devnode(dev));
impl = find_device_from_devnode(devnode);
if (impl) bus_event_queue_device_removed(&event_queue, &impl->unix_device);
else WARN("failed to find device for udev device %p\n", dev);
}