mirror of
https://gitlab.com/niansa/libcrosscoro.git
synced 2025-03-06 20:53:32 +01:00
e9b225e42f
* io_scheduler inline support * add debug info for io_scheduler size issue * move poll info into its own file * cleanup for feature * Fix valgrind introduced use after free with inline processing Running the coroutines inline with event processing caused a use after free bug with valgrind detected in the inline tcp server/client benchmark code. Basically if an event and a timeout occured in the same time period because the inline processing would resume _inline_ with the event or the timeout -- if the timeout and event occured in the same epoll_wait() function call then the second one's coroutine stackframe would already be destroyed upon resuming it so the poll_info->processed check would be reading already free'ed memory. The solution to this was to introduce a vector of coroutine handles which are appended into on each epoll_wait() iteration of events and timeouts, and only then after the events and timeouts are deduplicated are the coroutine handles resumed. This new vector has elided a malloc in the timeout function, but there is still a malloc to extract the poll infos from the timeout multimap data structure. The vector is also on the class member list and is only ever cleared, it is possible with a monster set of timeouts that this vector could grow extremely large, but I think that is worth the price of not re-allocating it.
33 lines
No EOL
1.1 KiB
C++
33 lines
No EOL
1.1 KiB
C++
#include "catch.hpp"
|
|
|
|
#include <coro/coro.hpp>
|
|
|
|
#include <chrono>
|
|
|
|
TEST_CASE("dns_resolver basic", "[dns]")
|
|
{
|
|
coro::io_scheduler scheduler{coro::io_scheduler::options{.pool = coro::thread_pool::options{.thread_count = 1}}};
|
|
coro::net::dns_resolver dns_resolver{scheduler, std::chrono::milliseconds{5000}};
|
|
|
|
auto make_host_by_name_task = [&](coro::net::hostname hn) -> coro::task<void> {
|
|
co_await scheduler.schedule();
|
|
auto result_ptr = co_await std::move(dns_resolver.host_by_name(hn));
|
|
|
|
if (result_ptr->status() == coro::net::dns_status::complete)
|
|
{
|
|
for (const auto& ip_addr : result_ptr->ip_addresses())
|
|
{
|
|
std::cerr << coro::net::to_string(ip_addr.domain()) << " " << ip_addr.to_string() << "\n";
|
|
}
|
|
}
|
|
|
|
co_return;
|
|
};
|
|
|
|
coro::sync_wait(make_host_by_name_task(coro::net::hostname{"www.example.com"}));
|
|
|
|
std::cerr << "io_scheduler.size() before shutdown = " << scheduler.size() << "\n";
|
|
scheduler.shutdown();
|
|
std::cerr << "io_scheduler.size() after shutdown = " << scheduler.size() << "\n";
|
|
REQUIRE(scheduler.empty());
|
|
} |