1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
linux/drivers/net/ethernet/sfc
Íñigo Huguet 25bde571b4 sfc/siena: fix wrong tx channel offset with efx_separate_tx_channels
tx_channel_offset is calculated in efx_allocate_msix_channels, but it is
also calculated again in efx_set_channels because it was originally done
there, and when efx_allocate_msix_channels was introduced it was
forgotten to be removed from efx_set_channels.

Moreover, the old calculation is wrong when using
efx_separate_tx_channels because now we can have XDP channels after the
TX channels, so n_channels - n_tx_channels doesn't point to the first TX
channel.

Remove the old calculation from efx_set_channels, and add the
initialization of this variable if MSI or legacy interrupts are used,
next to the initialization of the rest of the related variables, where
it was missing.

This has been already done for sfc, do it also for sfc_siena.

Fixes: 3990a8fffb ("sfc: allocate channels for XDP tx queues")
Reported-by: Tianhao Zhao <tizhao@redhat.com>
Signed-off-by: Íñigo Huguet <ihuguet@redhat.com>
Acked-by: Martin Habets <habetsm.xilinx@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2022-06-01 17:47:17 -07:00
..
falcon net: allow gso_max_size to exceed 65536 2022-05-16 10:18:55 +01:00
siena sfc/siena: fix wrong tx channel offset with efx_separate_tx_channels 2022-06-01 17:47:17 -07:00
bitfield.h sfc: extend bitfield macros to 19 fields 2020-11-13 15:33:03 -08:00
ef10.c Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2022-05-12 16:15:30 -07:00
ef10_regs.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
ef10_sriov.c ethernet: constify references to netdev->dev_addr in drivers 2021-10-14 09:22:11 -07:00
ef10_sriov.h ethernet: constify references to netdev->dev_addr in drivers 2021-10-14 09:22:11 -07:00
ef100.c sfc: add EF100 VF support via a write to sriov_numvfs 2022-04-29 18:43:01 -07:00
ef100.h sfc: skeleton EF100 PF driver 2020-07-27 12:26:55 -07:00
ef100_ethtool.c ethtool: extend ringparam setting/getting API with rx_buf_len 2021-11-22 12:31:49 +00:00
ef100_ethtool.h sfc: skeleton EF100 PF driver 2020-07-27 12:26:55 -07:00
ef100_netdev.c sfc: add ethtool ops and miscellaneous ndos to EF100 2020-09-07 14:46:13 -07:00
ef100_netdev.h sfc: skeleton EF100 PF driver 2020-07-27 12:26:55 -07:00
ef100_nic.c net: allow gso_max_size to exceed 65536 2022-05-16 10:18:55 +01:00
ef100_nic.h sfc_ef100: add nic-type for VFs, and bind to them 2020-08-03 18:22:55 -07:00
ef100_regs.h sfc_ef100: add EF100 register definitions 2020-07-27 12:26:55 -07:00
ef100_rx.c sfc: fix boolreturn.cocci warning and rename function 2020-08-24 18:14:23 -07:00
ef100_rx.h sfc: check hash is valid before using it 2020-08-14 14:07:16 -07:00
ef100_sriov.c sfc: add EF100 VF support via a write to sriov_numvfs 2022-04-29 18:43:01 -07:00
ef100_sriov.h sfc: add EF100 VF support via a write to sriov_numvfs 2022-04-29 18:43:01 -07:00
ef100_tx.c sfc: support GRE TSO on EF100 2020-11-13 15:33:30 -08:00
ef100_tx.h sfc: make ef100 xmit_more handling look more like ef10's 2020-09-05 12:21:39 -07:00
efx.c net: make drivers set the TSO limit not the GSO limit 2022-05-06 12:07:56 +01:00
efx.h sfc: Remove duplicate definition of efx_xmit_done 2022-04-12 12:13:30 +02:00
efx_channels.c sfc: fix wrong tx channel offset with efx_separate_tx_channels 2022-05-29 12:12:53 +01:00
efx_channels.h Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net 2022-05-12 16:15:30 -07:00
efx_common.c sfc: Remove global definition of efx_reset_type_names 2022-04-12 12:13:30 +02:00
efx_common.h sfc: advertise encapsulated offloads on EF10 2020-09-11 17:15:22 -07:00
enum.h sfc: Remove duplicate argument 2021-04-14 13:55:07 -07:00
ethtool.c ethtool: extend ringparam setting/getting API with rx_buf_len 2021-11-22 12:31:49 +00:00
ethtool_common.c sfc: Fix reading non-legacy supported link modes 2021-10-18 14:28:02 +01:00
ethtool_common.h sfc: skeleton EF100 PF driver 2020-07-27 12:26:55 -07:00
farch_regs.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
filter.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
io.h sfc_ef100: register accesses on EF100 2020-07-27 12:26:55 -07:00
Kconfig sfc/siena: Make MCDI logging support specific for Siena 2022-05-12 16:49:30 -07:00
Makefile sfc: Add a basic Siena module 2022-05-10 15:38:15 -07:00
mcdi.c sfc: extend the locking on mcdi->seqno 2022-03-03 14:11:58 +00:00
mcdi.h sfc: fix kdoc warning 2020-09-25 16:29:00 -07:00
mcdi_filters.c treewide: Use fallthrough pseudo-keyword 2020-08-23 17:36:59 -05:00
mcdi_filters.h sfc_ef100: helper function to set default RSS table of given size 2020-07-02 14:47:40 -07:00
mcdi_functions.c sfc: de-indirect TSO handling 2020-09-11 17:15:22 -07:00
mcdi_functions.h sfc: de-indirect TSO handling 2020-09-11 17:15:22 -07:00
mcdi_mon.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
mcdi_pcol.h sfc: Fix spelling mistake "writting" -> "writing" 2022-04-12 09:34:05 +02:00
mcdi_port.c sfc: remove phy_op indirection 2020-09-07 14:46:13 -07:00
mcdi_port.h sfc: move NIC-specific mcdi_port declarations out of common header 2020-06-30 13:09:09 -07:00
mcdi_port_common.c ethernet/sfc: remove redundant rc variable 2022-01-04 12:41:41 +00:00
mcdi_port_common.h sfc: coding style cleanups in mcdi_port_common.c 2020-09-08 20:14:33 -07:00
mtd.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
net_driver.h sfc: fix considering that all channels have TX queues 2022-05-29 12:12:53 +01:00
nic.c net:sfc: fix non-freed irq in legacy irq mode 2021-05-21 14:51:10 -07:00
nic.h sfc: Disable Siena support 2022-05-04 11:18:08 +01:00
nic_common.h sfc: The size of the RX recycle ring should be more flexible 2022-02-01 20:34:59 -08:00
ptp.c net: sfc: fix memory leak due to ptp channel 2022-05-09 10:01:48 +01:00
ptp.h net: sfc: fix memory leak due to ptp channel 2022-05-09 10:01:48 +01:00
rx.c bpf: Let bpf_warn_invalid_xdp_action() report more info 2021-12-13 22:28:27 +01:00
rx_common.c sfc: Do not free an empty page_ring 2022-04-04 12:53:52 +01:00
rx_common.h sfc: The size of the RX recycle ring should be more flexible 2022-02-01 20:34:59 -08:00
selftest.c sfc: define inner/outer csum offload TXQ types 2020-09-11 17:15:22 -07:00
selftest.h sfc: decouple TXQ type from label 2020-09-11 17:15:22 -07:00
sriov.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
sriov.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
tx.c sfc: use hardware tx timestamps for more than PTP 2022-04-08 14:43:10 -07:00
tx.h sfc: select inner-csum-offload TX queues for skbs that need it 2020-09-11 17:15:22 -07:00
tx_common.c net: allow gso_max_size to exceed 65536 2022-05-16 10:18:55 +01:00
tx_common.h sfc: skeleton EF100 PF driver 2020-07-27 12:26:55 -07:00
tx_tso.c treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
vfdi.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00
workarounds.h treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 500 2019-06-19 17:09:55 +02:00