1
0
Fork 0
mirror of synced 2025-03-06 20:59:54 +01:00
linux/drivers/net/ethernet/sfc/siena
Íñigo Huguet 25bde571b4 sfc/siena: fix wrong tx channel offset with efx_separate_tx_channels
tx_channel_offset is calculated in efx_allocate_msix_channels, but it is
also calculated again in efx_set_channels because it was originally done
there, and when efx_allocate_msix_channels was introduced it was
forgotten to be removed from efx_set_channels.

Moreover, the old calculation is wrong when using
efx_separate_tx_channels because now we can have XDP channels after the
TX channels, so n_channels - n_tx_channels doesn't point to the first TX
channel.

Remove the old calculation from efx_set_channels, and add the
initialization of this variable if MSI or legacy interrupts are used,
next to the initialization of the rest of the related variables, where
it was missing.

This has been already done for sfc, do it also for sfc_siena.

Fixes: 3990a8fffb ("sfc: allocate channels for XDP tx queues")
Reported-by: Tianhao Zhao <tizhao@redhat.com>
Signed-off-by: Íñigo Huguet <ihuguet@redhat.com>
Acked-by: Martin Habets <habetsm.xilinx@gmail.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2022-06-01 17:47:17 -07:00
..
bitfield.h sfc: Copy shared files needed for Siena (part 1) 2022-05-10 15:38:14 -07:00
efx.c sfc/siena: Reinstate SRIOV init/fini function calls 2022-05-12 16:49:30 -07:00
efx.h siena: Make SRIOV support specific for Siena 2022-05-12 16:49:29 -07:00
efx_channels.c sfc/siena: fix wrong tx channel offset with efx_separate_tx_channels 2022-06-01 17:47:17 -07:00
efx_channels.h sfc: siena: Have a unique wrapper ifndef for efx channels header 2022-05-18 20:07:58 -07:00
efx_common.c sfc/siena: Make PTP and reset support specific for Siena 2022-05-12 16:49:30 -07:00
efx_common.h sfc/siena: Make MCDI logging support specific for Siena 2022-05-12 16:49:30 -07:00
enum.h sfc/siena: Rename functions in efx headers to avoid conflicts with sfc 2022-05-10 15:38:14 -07:00
ethtool.c sfc/siena: Rename functions in nic_common.h to avoid conflicts with sfc 2022-05-10 15:38:15 -07:00
ethtool_common.c sfc/siena: Rename functions in mcdi headers to avoid conflicts with sfc 2022-05-10 15:38:15 -07:00
ethtool_common.h sfc/siena: Rename peripheral functions to avoid conflicts with sfc 2022-05-10 15:38:15 -07:00
farch.c siena: Make SRIOV support specific for Siena 2022-05-12 16:49:29 -07:00
farch_regs.h sfc: Copy shared files needed for Siena (part 1) 2022-05-10 15:38:14 -07:00
filter.h sfc: Copy shared files needed for Siena (part 1) 2022-05-10 15:38:14 -07:00
io.h sfc: Copy shared files needed for Siena (part 1) 2022-05-10 15:38:14 -07:00
Kconfig sfc: siena: Fix Kconfig dependencies 2022-05-13 10:18:57 -07:00
Makefile siena: Make SRIOV support specific for Siena 2022-05-12 16:49:29 -07:00
mcdi.c sfc/siena: Make MCDI logging support specific for Siena 2022-05-12 16:49:30 -07:00
mcdi.h sfc/siena: Make MCDI logging support specific for Siena 2022-05-12 16:49:30 -07:00
mcdi_mon.c siena: Make HWMON support specific for Siena 2022-05-12 16:49:29 -07:00
mcdi_pcol.h
mcdi_port.c sfc/siena: Rename functions in mcdi headers to avoid conflicts with sfc 2022-05-10 15:38:15 -07:00
mcdi_port.h sfc/siena: Rename functions in mcdi headers to avoid conflicts with sfc 2022-05-10 15:38:15 -07:00
mcdi_port_common.c sfc/siena: Rename functions in nic_common.h to avoid conflicts with sfc 2022-05-10 15:38:15 -07:00
mcdi_port_common.h sfc/siena: Rename functions in mcdi headers to avoid conflicts with sfc 2022-05-10 15:38:15 -07:00
mtd.c sfc/siena: Rename functions in efx headers to avoid conflicts with sfc 2022-05-10 15:38:14 -07:00
net_driver.h sfc/siena: fix considering that all channels have TX queues 2022-06-01 17:47:16 -07:00
nic.c sfc/siena: Rename functions in nic_common.h to avoid conflicts with sfc 2022-05-10 15:38:15 -07:00
nic.h siena: Make SRIOV support specific for Siena 2022-05-12 16:49:29 -07:00
nic_common.h sfc/siena: Rename functions in nic_common.h to avoid conflicts with sfc 2022-05-10 15:38:15 -07:00
ptp.c sfc/siena: Make PTP and reset support specific for Siena 2022-05-12 16:49:30 -07:00
ptp.h sfc/siena: Rename peripheral functions to avoid conflicts with sfc 2022-05-10 15:38:15 -07:00
rx.c sfc/siena: Rename peripheral functions to avoid conflicts with sfc 2022-05-10 15:38:15 -07:00
rx_common.c sfc/siena: Rename RX/TX functions to avoid conflicts with sfc 2022-05-10 15:38:14 -07:00
rx_common.h sfc/siena: Rename RX/TX functions to avoid conflicts with sfc 2022-05-10 15:38:14 -07:00
selftest.c sfc/siena: Rename functions in nic_common.h to avoid conflicts with sfc 2022-05-10 15:38:15 -07:00
selftest.h sfc/siena: Rename peripheral functions to avoid conflicts with sfc 2022-05-10 15:38:15 -07:00
siena.c siena: Make SRIOV support specific for Siena 2022-05-12 16:49:29 -07:00
siena_sriov.c sfc/siena: Rename functions in nic_common.h to avoid conflicts with sfc 2022-05-10 15:38:15 -07:00
siena_sriov.h sfc/siena: Reinstate SRIOV init/fini function calls 2022-05-12 16:49:30 -07:00
sriov.h siena: Make SRIOV support specific for Siena 2022-05-12 16:49:29 -07:00
tx.c sfc/siena: Remove duplicate check on segments 2022-05-20 16:46:49 -07:00
tx.h sfc/siena: Rename RX/TX functions to avoid conflicts with sfc 2022-05-10 15:38:14 -07:00
tx_common.c sfc/siena: Rename functions in nic_common.h to avoid conflicts with sfc 2022-05-10 15:38:15 -07:00
tx_common.h sfc/siena: Rename RX/TX functions to avoid conflicts with sfc 2022-05-10 15:38:14 -07:00
vfdi.h sfc: Copy shared files needed for Siena (part 2) 2022-05-10 15:38:14 -07:00
workarounds.h sfc/siena: Remove build references to missing functionality 2022-05-10 15:38:14 -07:00